Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add object tagging - Moodle 42 #623

Merged
merged 1 commit into from
Dec 6, 2024
Merged

Conversation

matthewhilton
Copy link
Contributor

@matthewhilton matthewhilton marked this pull request as ready for review August 4, 2024 23:06
@matthewhilton
Copy link
Contributor Author

Leaving as draft until #619 is in a mergeable-state

@matthewhilton matthewhilton marked this pull request as draft August 16, 2024 01:16
@matthewhilton matthewhilton marked this pull request as ready for review September 29, 2024 23:21
@matthewhilton
Copy link
Contributor Author

Rebased, but marking as draft again since the 310 PR has made some changes that i'll need to cherry pick over

@matthewhilton matthewhilton marked this pull request as draft October 1, 2024 01:19
@matthewhilton matthewhilton force-pushed the object-tagging-42 branch 2 times, most recently from cdb21ff to 57e0202 Compare November 21, 2024 01:04
@matthewhilton matthewhilton marked this pull request as ready for review November 21, 2024 01:11
* feat: add object tagging

* test: fix unit test count checking

* tagging: don't wait for object lock

* tagging: improve migration controls and progress visibility

* feat: move tagging status reports to check api

* feat: display header with status report

* refactor: integrate tagpushedtime into single update query

* refactor: store tags against object id instead of hash

* chore: organise tagging lang strings

* bugfix: fix mysql query compatibility

* tagging: move mimetype to metadata, add location/orphan tag source

* tagging: check environment config length

* settings: use admin_setting_check if available

* report: remove object size from tag count report

* tagging: ignore if cannot get lock

* ci: small fixups

* tagging: switch  to admin setting for tagging environment

* refactor: get object tag sync status count details separately

* refactor: tweak defaults and add tagging adhoc task spawn limit

* tests: reset static file storage before tests

* bugfix: fix test

* ci: fixup
@matthewhilton
Copy link
Contributor Author

Just updated this PR:

  • Cherry picked the squashed commit from Add object tagging - Moodle 310 #619
  • Completed manual testing including upgrading - works as expected
  • Ran phpunit tests with the s3 integration client - no issues other than expected perms issue (e.g. trying to test delete but token has no delete perms)

Once the CI is good, i'll merge this in.

@matthewhilton matthewhilton merged commit 883f210 into MOODLE_402_STABLE Dec 6, 2024
23 checks passed
@matthewhilton matthewhilton deleted the object-tagging-42 branch December 6, 2024 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants